{ "_class" : "hudson.matrix.MatrixBuild", "actions" : [ { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "org.jenkinsci.plugins.ghprb.GhprbCause", "shortDescription" : "GitHub pull request #3579 of commit b2e880989e549500dc7e67fca4b7d808b9493d32, no merge conflicts." } ] }, { "_class" : "org.jenkinsci.plugins.ghprb.GhprbParametersAction", "parameters" : [ { "_class" : "hudson.model.StringParameterValue", "name" : "sha1", "value" : "origin/pr/3579/merge" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbActualCommit", "value" : "b2e880989e549500dc7e67fca4b7d808b9493d32" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbActualCommitAuthor", "value" : "Dave Marchevsky" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbActualCommitAuthorEmail", "value" : "davemarchevsky@fb.com" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbAuthorRepoGitUrl", "value" : "https://github.com/davemarchevsky/bcc.git" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthor", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthorEmail", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthorLogin", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthorLoginMention", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullId", "value" : "3579" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTargetBranch", "value" : "master" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbSourceBranch", "value" : "davemarchevsky_perf_event_improvement" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GIT_BRANCH", "value" : "davemarchevsky_perf_event_improvement" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullAuthorEmail", "value" : "davemarchevsky@gmail.com" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullAuthorLogin", "value" : "davemarchevsky" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullAuthorLoginMention", "value" : "@davemarchevsky" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullDescription", "value" : "GitHub pull request #3579 of commit b2e880989e549500dc7e67fca4b7d808b9493d32, no merge conflicts." }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullTitle", "value" : "bcc/python: Improvements to python perf_event_attr ctype" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullLink", "value" : "https://github.com/iovisor/bcc/pull/3579" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullLongDescription", "value" : "Discussion in #3571 identified some low-hanging fruit improvements to the perf_event_attr ctype. This PR adds these improvements as well as adding the new test from #3571 to CMakeFiles.\\r\\n\\r\\nTwo commits, one focused on the perf_event_attr improvements:\\r\\n\\r\\n```\\r\\n bcc/python: extend perf_event_attr ctype\\r\\n\\r\\n This commit brings the Perf.perf_event_attr ctype in line with version 6\\r\\n of struct perf_event_attr (see uapi/linux/perf_event.h kernel header).\\r\\n Specifically:\\r\\n * All named fields are added, including field names within anonymous\\r\\n unions and bitfields\\r\\n * Perf.perf_event_attr now complains when a field which isn't part of\\r\\n the ctype struct is set.\\r\\n * Goal here is to prevent users from setting a\\r\\n recently-added field - which we haven't updated the ctype _fields_ to\\r\\n include - and getting confused when it doesn't propagate to the\\r\\n perf_event_open syscall. This bit me in #3571 and I am pretty\\r\\n familiar with bcc internals so I'd like to prevent this from\\r\\n confusing others down the line.\\r\\n * Perf.perf_event_attr's 'flags' field is removed as it was a standin\\r\\n for the bitfields. The _old_ profile.py was the only script in bcc\\r\\n tools that I could find using this.\\r\\n\\r\\n The last bullet is a breaking change. Although `tools/old/profile.py`\\r\\n has been migrated to use the bitfield it was flipping using `flags`,\\r\\n there could be some scripts out in the wild which break. I don't think\\r\\n this is likely: this stuff hasn't been significantly touched since 2016\\r\\n and I suspect if users of the python interface were writing lots of\\r\\n perf_event programs we would've seen more python tools or activity here.\\r\\n\\r\\n Regardless, there is probably a way to keep `flags` field working while\\r\\n also exposing named bitfields, but I suspect it'll be ugly and wanted to\\r\\n see if anyone thought it was necessary.\\r\\n```\\r\\n\\r\\nand the second on the test and pseudo-enum convenience class:\\r\\n\\r\\n```\\r\\n bcc/python: Add test_attach_perf_event.py to CMake tests\\r\\n\\r\\n Add to CMakeLists.txt of tests so that the test is run as part of github\\r\\n actions test suite. Shorten the sleep duration so test finishes faster -\\r\\n since it's just testing attach currently the extra time isn't producing\\r\\n more signal.\\r\\n\\r\\n Also add python equivalent of `perf_event_sample_format` enum so\\r\\n `sample_type` can be more clearly set.\\r\\n```\\r\\n\\r\\n/cc @athira-rajeev " }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbCommentBody", "value" : "null" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbGhRepository", "value" : "iovisor/bcc" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbCredentialsId", "value" : "6d3daf13-69b8-48b1-9c8f-ec5353264113" } ] }, { }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" } ], "artifacts" : [ ], "building" : False, "description" : "PR #3579: bcc/python: Improvements to...", "displayName" : "#1115", "duration" : 1217986, "estimatedDuration" : 7460664, "executor" : None, "fullDisplayName" : "bcc-pr #1115", "id" : "1115", "keepLog" : False, "number" : 1115, "queueId" : 8929, "result" : "FAILURE", "timestamp" : 1628924293236, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/1115/", "builtOn" : "", "changeSet" : { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ ], "kind" : "git" }, "culprits" : [ ], "runs" : [ { "number" : 1115, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc25/1115/" }, { "number" : 1115, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc26/1115/" }, { "number" : 1115, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc27/1115/" }, { "number" : 1115, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc28/1115/" }, { "number" : 1115, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1604/1115/" }, { "number" : 1115, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1710/1115/" }, { "number" : 1115, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1804/1115/" } ] }