{ "_class" : "hudson.matrix.MatrixBuild", "actions" : [ { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "org.jenkinsci.plugins.ghprb.GhprbCause", "shortDescription" : "GitHub pull request #3579 of commit 6727ea2ae46acc5aaeb1a2b4eee43d9e15d2f38b, no merge conflicts." } ] }, { "_class" : "org.jenkinsci.plugins.ghprb.GhprbParametersAction", "parameters" : [ { "_class" : "hudson.model.StringParameterValue", "name" : "sha1", "value" : "origin/pr/3579/merge" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbActualCommit", "value" : "6727ea2ae46acc5aaeb1a2b4eee43d9e15d2f38b" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbActualCommitAuthor", "value" : "Dave Marchevsky" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbActualCommitAuthorEmail", "value" : "davemarchevsky@fb.com" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbAuthorRepoGitUrl", "value" : "https://github.com/davemarchevsky/bcc.git" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthor", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthorEmail", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthorLogin", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTriggerAuthorLoginMention", "value" : "" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullId", "value" : "3579" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbTargetBranch", "value" : "master" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbSourceBranch", "value" : "davemarchevsky_perf_event_improvement" }, { "_class" : "hudson.model.StringParameterValue", "name" : "GIT_BRANCH", "value" : "davemarchevsky_perf_event_improvement" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullAuthorEmail", "value" : "davemarchevsky@gmail.com" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullAuthorLogin", "value" : "davemarchevsky" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullAuthorLoginMention", "value" : "@davemarchevsky" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullDescription", "value" : "GitHub pull request #3579 of commit 6727ea2ae46acc5aaeb1a2b4eee43d9e15d2f38b, no merge conflicts." }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullTitle", "value" : "bcc/python: Improvements to python perf_event_attr ctype" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullLink", "value" : "https://github.com/iovisor/bcc/pull/3579" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbPullLongDescription", "value" : "Discussion in #3571 identified some low-hanging fruit improvements to the perf_event_attr ctype. This PR adds these improvements as well as adding the new test from #3571 to CMakeFiles.\\r\\n\\r\\nFirst commit focuses on `perf_event_attr` ctype improvements: \\r\\n\\r\\n```\\r\\n bcc/python: extend perf_event_attr ctype\\r\\n\\r\\n This commit brings the Perf.perf_event_attr ctype in line with version 6\\r\\n of struct perf_event_attr (see uapi/linux/perf_event.h kernel header).\\r\\n Specifically:\\r\\n * All named fields are added, including field names within anonymous\\r\\n unions and bitfields\\r\\n * Perf.perf_event_attr now complains when a field which isn't part of\\r\\n the ctype struct is set.\\r\\n * Goal here is to prevent users from setting a\\r\\n recently-added field - which we haven't updated the ctype _fields_ to\\r\\n include - and getting confused when it doesn't propagate to the\\r\\n perf_event_open syscall. This bit me in #3571 and I am pretty\\r\\n familiar with bcc internals so I'd like to prevent this from\\r\\n confusing others down the line.\\r\\n * Perf.perf_event_attr's 'flags' field is removed as it was a standin\\r\\n for the bitfields. The _old_ profile.py was the only script in bcc\\r\\n tools that I could find using this.\\r\\n\\r\\n The last bullet is a breaking change. Although `tools/old/profile.py`\\r\\n has been migrated to use the bitfield it was flipping using `flags`,\\r\\n there could be some scripts out in the wild which break. I don't think\\r\\n this is likely: this stuff hasn't been significantly touched since 2016\\r\\n and I suspect if users of the python interface were writing lots of\\r\\n perf_event programs we would've seen more python tools or activity here.\\r\\n\\r\\n Regardless, there is probably a way to keep `flags` field working while\\r\\n also exposing named bitfields, but I suspect it'll be ugly and wanted to\\r\\n see if anyone thought it was necessary.\\r\\n```\\r\\n\\r\\nsecond pulls out kernel_version_ge into utils for use in further commits:\\r\\n\\r\\n```\\r\\n bcc/python tests: pull kernel_version_ge into utils\\r\\n\\r\\n This helper is replicated in a few different places, let's pull it out.\\r\\n```\\r\\n\\r\\nthird adds `test_attach_perf_event.py` to test infra. The single test in that file fails due to old kernel headers on ubuntu 16.04, and regardless fails on everything due to lack of hw perf event support\\r\\n\\r\\n```\\r\\n bcc/python: Add test_attach_perf_event.py to CMake tests\\r\\n\\r\\n Add to CMakeLists.txt of tests so that the test is run as part of github\\r\\n actions test suite. Shorten the sleep duration so test finishes faster -\\r\\n since it's just testing attach currently the extra time isn't producing\\r\\n more signal.\\r\\n\\r\\n Also add python equivalent of `perf_event_sample_format` enum so\\r\\n `sample_type` can be more clearly set.\\r\\n\\r\\n v2: The test doesn't work on ubuntu 16.04 due to old kernel headers. It\\r\\n doesn't work on the rest of the github actions VMs due to hardware perf\\r\\n events not being supported, so add necessary check / skip.\\r\\n```\\r\\n\\r\\n/cc @athira-rajeev " }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbCommentBody", "value" : "null" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbGhRepository", "value" : "iovisor/bcc" }, { "_class" : "hudson.model.StringParameterValue", "name" : "ghprbCredentialsId", "value" : "6d3daf13-69b8-48b1-9c8f-ec5353264113" } ] }, { }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" } ], "artifacts" : [ ], "building" : False, "description" : "PR #3579: bcc/python: Improvements to...", "displayName" : "#1117", "duration" : 1194967, "estimatedDuration" : 7460664, "executor" : None, "fullDisplayName" : "bcc-pr #1117", "id" : "1117", "keepLog" : False, "number" : 1117, "queueId" : 8945, "result" : "FAILURE", "timestamp" : 1628932083381, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/1117/", "builtOn" : "", "changeSet" : { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ ], "kind" : "git" }, "culprits" : [ ], "runs" : [ { "number" : 1117, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc25/1117/" }, { "number" : 1117, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc26/1117/" }, { "number" : 1117, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc27/1117/" }, { "number" : 1117, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc28/1117/" }, { "number" : 1117, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1604/1117/" }, { "number" : 1117, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1710/1117/" }, { "number" : 1117, "url" : "https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1804/1117/" } ] }