GitHub pull request #2790 of commit eb0184471c4edfd5d00884ed215ff40d3c5afd78, no merge conflicts.sha1origin/pr/2790/mergeghprbActualCommiteb0184471c4edfd5d00884ed215ff40d3c5afd78ghprbActualCommitAuthorghprbActualCommitAuthorEmailghprbAuthorRepoGitUrlhttps://github.com/nick-arm/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginyonghong-songghprbTriggerAuthorLoginMention@yonghong-songghprbPullId2790ghprbTargetBranchmasterghprbSourceBranchfix-usdtGIT_BRANCHfix-usdtghprbPullAuthorEmailghprbPullAuthorLoginnick-armghprbPullAuthorLoginMention@nick-armghprbPullDescriptionGitHub pull request #2790 of commit eb0184471c4edfd5d00884ed215ff40d3c5afd78, no merge conflicts.ghprbPullTitleusdt: fix parsing sp register in arguments on AArch64ghprbPullLinkhttps://github.com/iovisor/bcc/pull/2790ghprbPullLongDescriptionOne of the USDT probes for OpenJDK on AArch64 has an argument as an\r\noffset from the stack pointer register like \"8@[sp, 112]\". This causes\r\nthe argument parser to fail:\r\n\r\n Parse error:\r\n 8@x22 8@x20 8@x23 8@x0 8@x26 8@x27 8@[sp, 112] 8@[sp, 120]\r\n ------------------------------------------^\r\n\r\nThe error message then repeats forever.\r\n\r\nChanged ArgumentParser_aarch64::parse_register so it accepts either\r\n\"xNN\" or \"sp\" and outputs the register name rather than the register\r\nnumber. The stack pointer is in a separate field `sp` in `struct pt_regs`\r\nrather than in the `regs[]` array. See:\r\n\r\nhttps://elixir.bootlin.com/linux/latest/source/arch/arm64/include/asm/ptrace.h#L160\r\n\r\nNote that the parser currently accepts \"x31\" and converts that into a\r\nreference to `regs[31]` but that array only has 31 elements. Made x31 an\r\nalias for `sp` to avoid undefined behaviour from reading past the end of\r\nthe array.\r\n\r\nChange-Id: I88b6ff741914b5d06ad5798a55bd21ea03f69825\r\nSigned-off-by: Nick Gasson <nick.gasson@arm.com>ghprbCommentBody[buildbot, test this please]ghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="usdt: fix parsing sp register in arguments on AArch64" href="https://github.com/iovisor/bcc/pull/2790">PR #2790</a>: usdt: fix parsing sp regist...#36812728627460664bcc-pr #368368false3682952FAILURE1583395316417https://buildbot.iovisor.org/jenkins/job/bcc-pr/368/git368https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc25/368/368https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc26/368/368https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc27/368/368https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=fc28/368/368https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1604/368/368https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1710/368/368https://buildbot.iovisor.org/jenkins/job/bcc-pr/label=ubuntu1804/368/