GitHub pull request #2936 of commit cdcf139720b0d5723b0027ae76f66d4a4fd384fc, no merge conflicts.sha1origin/pr/2936/mergeghprbActualCommitcdcf139720b0d5723b0027ae76f66d4a4fd384fcghprbActualCommitAuthorYonghong SongghprbActualCommitAuthorEmailyhs@fb.comghprbAuthorRepoGitUrlhttps://github.com/iovisor/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginghprbTriggerAuthorLoginMentionghprbPullId2936ghprbTargetBranchmasterghprbSourceBranchyhs_devGIT_BRANCHyhs_devghprbPullAuthorEmailghprbPullAuthorLoginyonghong-songghprbPullAuthorLoginMention@yonghong-songghprbPullDescriptionGitHub pull request #2936 of commit cdcf139720b0d5723b0027ae76f66d4a4fd384fc, no merge conflicts.ghprbPullTitlereturn failure if rewriter cannot rewrite properlyghprbPullLinkhttps://github.com/iovisor/bcc/pull/2936ghprbPullLongDescriptionFix issue #537.\r\n\r\nThe bcc rewriter does not have enough information to do\r\nproper rewriting from:\r\n```\r\n #define PKT_LEN_ADD 1\r\n ip->tlen += PKT_LEN_ADD;\r\n```\r\nto\r\n```\r\n bpf_dins_pkt(skb, (u64)ip+2, 0, 16, PKT_LEN_ADD);\r\n```\r\n\r\nSo instead of generate incorrect code\r\nwhich caused compilation error. Let return an error\r\nearlier with helper comments so users know what to do.\r\nWith this patch, we will have\r\n```\r\n /virtual/main.c:20:17: error: cannot have macro at the end of expresssion,\r\n workaround: put perentheses around macro \"(MARCO)\"\r\n ip->tlen += PKT_LEN_ADD;\r\n ^\r\n```ghprbCommentBodynullghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="return failure if rewriter cannot rewrite properly" href="https://github.com/iovisor/bcc/pull/2936">PR #2936</a>: return failure if rewriter ...#51013021537460664bcc-pr #510510false5104088SUCCESS1590512622904https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/510/git510https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/label=fc25/510/510https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/label=fc26/510/510https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/label=fc27/510/510https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/label=fc28/510/510https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/label=ubuntu1604/510/510https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/label=ubuntu1710/510/510https://buildbot.iovisor.org/jenkins/user/a.s.protopopov/my-views/view/all/job/bcc-pr/label=ubuntu1804/510/