GitHub pull request #3278 of commit beaee5e7cda9a22ee7d364fee55203db4afefbfc, no merge conflicts.sha1origin/pr/3278/mergeghprbActualCommitbeaee5e7cda9a22ee7d364fee55203db4afefbfcghprbActualCommitAuthorghprbActualCommitAuthorEmailghprbAuthorRepoGitUrlhttps://github.com/springmeyer/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginyonghong-songghprbTriggerAuthorLoginMention@yonghong-songghprbPullId3278ghprbTargetBranchmasterghprbSourceBranchmasterGIT_BRANCHmasterghprbPullAuthorEmailghprbPullAuthorLoginspringmeyerghprbPullAuthorLoginMention@springmeyerghprbPullDescriptionGitHub pull request #3278 of commit beaee5e7cda9a22ee7d364fee55203db4afefbfc, no merge conflicts.ghprbPullTitleFix compile error: call to 'make_unique' is ambiguousghprbPullLinkhttps://github.com/iovisor/bcc/pull/3278ghprbPullLongDescription## Problem\r\n\r\nWhen building with c++14 `std::make_unique` is available. This surfaces a bug in the code whereby the `src/cc/frontends/b/loader.cc` breaks like:\r\n\r\n```\r\nFAILED: src/cc/frontends/b/CMakeFiles/b_frontend.dir/loader.cc.o \r\n/home/myuser/mason/mason_packages/linux-x86_64/llvm/11.0.0/bin/clang++ -fPIC -stdlib=libc++ -std=c++14 -Wall -fno-rtti -fPIC -DBCC_PROG_TAG_DIR='\"/var/tmp/bcc\"' -DLLVM_MAJOR_VERSION=11 -O3 -DNDEBUG -I/home/myuser/mason/mason_packages/linux-x86_64/llvm/11.0.0/include/../tools/clang/include -I../src -Isrc -Isrc/cc -I../src/cc -Isrc/cc/frontends/b -I../src/cc/frontends/b -I../src/cc/frontends/clang -I/home/myuser/mason/mason_packages/linux-x86_64/llvm/11.0.0/include -I/home/myuser/mason/mason_packages/linux-x86_64/elfutils/0.170/include -I../src/cc/compat -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -MMD -MT src/cc/frontends/b/CMakeFiles/b_frontend.dir/loader.cc.o -MF \"src/cc/frontends/b/CMakeFiles/b_frontend.dir/loader.cc.o.d\" -o src/cc/frontends/b/CMakeFiles/b_frontend.dir/loader.cc.o -c ../src/cc/frontends/b/loader.cc\r\n../src/cc/frontends/b/loader.cc:39:19: error: call to 'make_unique' is ambiguous\r\n proto_parser_ = make_unique<ebpf::cc::Parser>(proto_filename);\r\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/home/myuser/mason/mason_packages/linux-x86_64/llvm/11.0.0/bin/../include/c++/v1/memory:2925:1: note: candidate function [with _Tp = ebpf::cc::Parser, _Args = <const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> &>]\r\nmake_unique(_Args&&... __args)\r\n^\r\n../src/cc/common.h:28:1: note: candidate function [with T = ebpf::cc::Parser, Args = <const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> &>]\r\nmake_unique(Args &&... args) {\r\n^\r\n../src/cc/frontends/b/loader.cc:46:13: error: call to 'make_unique' is ambiguous\r\n parser_ = make_unique<ebpf::cc::Parser>(filename);\r\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/home/myuser/mason/mason_packages/linux-x86_64/llvm/11.0.0/bin/../include/c++/v1/memory:2925:1: note: candidate function [with _Tp = ebpf::cc::Parser, _Args = <const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> &>]\r\nmake_unique(_Args&&... __args)\r\n^\r\n../src/cc/common.h:28:1: note: candidate function [with T = ebpf::cc::Parser, Args = <const std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> &>]\r\nmake_unique(Args &&... args) {\r\n^\r\n```\r\n\r\n## Solution\r\n\r\nI'm able to fix this by including `common.h` in `loader.cc`. ghprbCommentBody[buildbot, test this please]ghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="Fix compile error: call to 'make_unique' is ambiguous" href="https://github.com/iovisor/bcc/pull/3278">PR #3278</a>: Fix compile error: call to ...#84311636637460664bcc-pr #843843false8436753SUCCESS1613954220004https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/843/git843https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/label=fc25/843/843https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/label=fc26/843/843https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/label=fc27/843/843https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/label=fc28/843/843https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/label=ubuntu1604/843/843https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/label=ubuntu1710/843/843https://buildbot.iovisor.org/jenkins/user/davemarchevsky/my-views/view/all/job/bcc-pr/label=ubuntu1804/843/