GitHub pull request #2742 of commit e1dc8642feddde8030e14ded2eaa475749718a40, no merge conflicts.sha1origin/pr/2742/mergeghprbActualCommite1dc8642feddde8030e14ded2eaa475749718a40ghprbActualCommitAuthorYonghong SongghprbActualCommitAuthorEmailyhs@fb.comghprbAuthorRepoGitUrlhttps://github.com/iovisor/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginghprbTriggerAuthorLoginMentionghprbPullId2742ghprbTargetBranchmasterghprbSourceBranchyhs_devGIT_BRANCHyhs_devghprbPullAuthorEmailghprbPullAuthorLoginyonghong-songghprbPullAuthorLoginMention@yonghong-songghprbPullDescriptionGitHub pull request #2742 of commit e1dc8642feddde8030e14ded2eaa475749718a40, no merge conflicts.ghprbPullTitleDo not rewrite array subscripts if invalid sourceloc rangeghprbPullLinkhttps://github.com/iovisor/bcc/pull/2742ghprbPullLongDescriptionFix #2739.\r\n\r\nThe issue exposed an issue that to rewrite\r\n CODE1: __u8 byte = daddr->s6_addr[4];\r\nwill segfault and to rewrite\r\n CODE2: __u8 byte = (daddr->s6_addr)[4];\r\nwill be okay.\r\n\r\nFor CODE1, the clang did not give enough information to find the text\r\nwhich contains the left bracket \"[\", given base \"daddr->s6_addr\"\r\nand subscript \"4\". For CODE2, the clang is able to get the information\r\nsuccessfuly.\r\n\r\nI think if we really go inside the base \"daddr->s6_addr\" and gets to\r\nits member field \"s6_addr\", we can find the needed information\r\nfor the text range containing \"[\". Let us fix the segfault first\r\nand if really desirable, we can try to enhance later for CODE1 patterns.\r\n\r\nSigned-off-by: Yonghong Song <yhs@fb.com>ghprbCommentBodynullghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="Do not rewrite array subscripts if invalid sourceloc range" href="https://github.com/iovisor/bcc/pull/2742">PR #2742</a>: Do not rewrite array subscr...#30814548757460664bcc-pr #308308false3082479SUCCESS1581021761683https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/308/git308https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/label=fc25/308/308https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/label=fc26/308/308https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/label=fc27/308/308https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/label=fc28/308/308https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/label=ubuntu1604/308/308https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/label=ubuntu1710/308/308https://buildbot.iovisor.org/jenkins/user/ethercflow/my-views/view/all/job/bcc-pr/label=ubuntu1804/308/