GitHub pull request #3579 of commit 6591eaf86fff6e87a31fbe46f468bcb4fc08dc11, no merge conflicts.sha1origin/pr/3579/mergeghprbActualCommit6591eaf86fff6e87a31fbe46f468bcb4fc08dc11ghprbActualCommitAuthorDave MarchevskyghprbActualCommitAuthorEmaildavemarchevsky@fb.comghprbAuthorRepoGitUrlhttps://github.com/davemarchevsky/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginghprbTriggerAuthorLoginMentionghprbPullId3579ghprbTargetBranchmasterghprbSourceBranchdavemarchevsky_perf_event_improvementGIT_BRANCHdavemarchevsky_perf_event_improvementghprbPullAuthorEmaildavemarchevsky@gmail.comghprbPullAuthorLogindavemarchevskyghprbPullAuthorLoginMention@davemarchevskyghprbPullDescriptionGitHub pull request #3579 of commit 6591eaf86fff6e87a31fbe46f468bcb4fc08dc11, no merge conflicts.ghprbPullTitlebcc/python: Improvements to python perf_event_attr ctypeghprbPullLinkhttps://github.com/iovisor/bcc/pull/3579ghprbPullLongDescriptionDiscussion in #3571 identified some low-hanging fruit improvements to the perf_event_attr ctype. This PR adds these improvements as well as adding the new test from #3571 to CMakeFiles.\r\n\r\nTwo commits, one focused on the perf_event_attr improvements:\r\n\r\n```\r\n bcc/python: extend perf_event_attr ctype\r\n\r\n This commit brings the Perf.perf_event_attr ctype in line with version 6\r\n of struct perf_event_attr (see uapi/linux/perf_event.h kernel header).\r\n Specifically:\r\n * All named fields are added, including field names within anonymous\r\n unions and bitfields\r\n * Perf.perf_event_attr now complains when a field which isn't part of\r\n the ctype struct is set.\r\n * Goal here is to prevent users from setting a\r\n recently-added field - which we haven't updated the ctype _fields_ to\r\n include - and getting confused when it doesn't propagate to the\r\n perf_event_open syscall. This bit me in #3571 and I am pretty\r\n familiar with bcc internals so I'd like to prevent this from\r\n confusing others down the line.\r\n * Perf.perf_event_attr's 'flags' field is removed as it was a standin\r\n for the bitfields. The _old_ profile.py was the only script in bcc\r\n tools that I could find using this.\r\n\r\n The last bullet is a breaking change. Although `tools/old/profile.py`\r\n has been migrated to use the bitfield it was flipping using `flags`,\r\n there could be some scripts out in the wild which break. I don't think\r\n this is likely: this stuff hasn't been significantly touched since 2016\r\n and I suspect if users of the python interface were writing lots of\r\n perf_event programs we would've seen more python tools or activity here.\r\n\r\n Regardless, there is probably a way to keep `flags` field working while\r\n also exposing named bitfields, but I suspect it'll be ugly and wanted to\r\n see if anyone thought it was necessary.\r\n```\r\n\r\nand the second on the test and pseudo-enum convenience class:\r\n\r\n```\r\n bcc/python: Add test_attach_perf_event.py to CMake tests\r\n\r\n Add to CMakeLists.txt of tests so that the test is run as part of github\r\n actions test suite. Shorten the sleep duration so test finishes faster -\r\n since it's just testing attach currently the extra time isn't producing\r\n more signal.\r\n\r\n Also add python equivalent of `perf_event_sample_format` enum so\r\n `sample_type` can be more clearly set.\r\n```\r\n\r\n/cc @athira-rajeev ghprbCommentBodynullghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="bcc/python: Improvements to python perf_event_attr ctype" href="https://github.com/iovisor/bcc/pull/3579">PR #3579</a>: bcc/python: Improvements to...#11138299117460664bcc-pr #11131113false11138913FAILURE1628914396741https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/1113/git1113https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/label=fc25/1113/1113https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/label=fc26/1113/1113https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/label=fc27/1113/1113https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/label=fc28/1113/1113https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/label=ubuntu1604/1113/1113https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/label=ubuntu1710/1113/1113https://buildbot.iovisor.org/jenkins/user/jmarchan/my-views/view/all/job/bcc-pr/label=ubuntu1804/1113/