GitHub pull request #2685 of commit f4499ad46a4e54b4c0156e9f32e283dcba937040, no merge conflicts.sha1origin/pr/2685/mergeghprbActualCommitf4499ad46a4e54b4c0156e9f32e283dcba937040ghprbActualCommitAuthorPaul ChaignonghprbActualCommitAuthorEmailpaul.chaignon@orange.comghprbAuthorRepoGitUrlhttps://github.com/pchaigno/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginghprbTriggerAuthorLoginMentionghprbPullId2685ghprbTargetBranchmasterghprbSourceBranchfix-rewrite-ext-ptr-indirectionsGIT_BRANCHfix-rewrite-ext-ptr-indirectionsghprbPullAuthorEmailpaul.chaignon@gmail.comghprbPullAuthorLoginpchaignoghprbPullAuthorLoginMention@pchaignoghprbPullDescriptionGitHub pull request #2685 of commit f4499ad46a4e54b4c0156e9f32e283dcba937040, no merge conflicts.ghprbPullTitlerewriter: Fix tracking of pointers with several indirectionsghprbPullLinkhttps://github.com/iovisor/bcc/pull/2685ghprbPullLongDescriptionThe rewriter tracks, with `nb_derefs`, the number of indirections of external pointers, to rewrite only the appropriate dereference into a call to `bpf_probe_read`.\r\n\r\nIn `ProbeChecker`, however, `nb_derefs` has a different meaning: it counts the number of dereferences encountered. This difference resulted in an error when `ProbeChecker` is traversing the right-hand side of an assignment. This pull request fixes the error and adds tests for the two cases of assignments: (1) when the right-hand side is an external pointer with several indirection levels and (2) when it is a call to a function returning an external pointer with several indirection levels.\r\n\r\nThis pull request also changes `ProbeSetter` and `assignsExtPtr` to count dereferences instead of addrof in an effort to use `nb_derefs` more consistently across the code to mean \"number of dereferences needed to get to the external pointer\".ghprbCommentBodynullghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="rewriter: Fix tracking of pointers with several indirections" href="https://github.com/iovisor/bcc/pull/2685">PR #2685</a>: rewriter: Fix tracking of p...#21610776027460664bcc-pr #216216false2161750SUCCESS1578212823389https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/216/git216https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/label=fc25/216/216https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/label=fc26/216/216https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/label=fc27/216/216https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/label=fc28/216/216https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/label=ubuntu1604/216/216https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/label=ubuntu1710/216/216https://buildbot.iovisor.org/jenkins/user/yhs/my-views/view/all/job/bcc-pr/label=ubuntu1804/216/