GitHub pull request #3016 of commit 7bab12b92a11e875420504744d1c056f07be724c, no merge conflicts.sha1origin/pr/3016/mergeghprbActualCommit7bab12b92a11e875420504744d1c056f07be724cghprbActualCommitAuthorghprbActualCommitAuthorEmailghprbAuthorRepoGitUrlhttps://github.com/michalgr/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginyonghong-songghprbTriggerAuthorLoginMention@yonghong-songghprbPullId3016ghprbTargetBranchmasterghprbSourceBranchfix_bcc_elf_symbol_strGIT_BRANCHfix_bcc_elf_symbol_strghprbPullAuthorEmailghprbPullAuthorLoginmichalgrghprbPullAuthorLoginMention@michalgrghprbPullDescriptionGitHub pull request #3016 of commit 7bab12b92a11e875420504744d1c056f07be724c, no merge conflicts.ghprbPullTitlefix debug file lookup in bcc_elf_symbol_strghprbPullLinkhttps://github.com/iovisor/bcc/pull/3016ghprbPullLongDescriptionLogic for looking up debug file in bcc_elf_symbol_str and foreach_sym_core\r\ndiffer. This commit factors out relevant code from foreach_sym_core and reuses\r\nit in bcc_elf_symbol_str.\r\n\r\nWithout this change symfs symbolication of stack traces captured by trace.py on\r\nAndroid does not work very well. Bpftrace which does not use lazy symbol name\r\nlookup is not affected though.\r\n\r\nStack traces captured with trace.py without this commit:\r\n```\r\n6475 6515 RenderThread _ZN10EglDisplay10InitializeEv\r\n b'EglDisplay::Initialize()+0x0 [libGLESv2_adreno.so]'\r\n b'[unknown] [libEGL.so]'\r\n b'[unknown] [libhwui.so]'\r\n b'[unknown] [libhwui.so]'\r\n b'[unknown] [libhwui.so]'\r\n b'[unknown] [libhwui.so]'\r\n b'[unknown] [libhwui.so]'\r\n b'[unknown] [libhwui.so]'\r\n b'[unknown] [libutils.so]'\r\n b'[unknown] [libc.so]'\r\n b'[unknown] [libc.so]'\r\n\r\n6491 6636 Thread-8 _ZN10EglDisplay10InitializeEv\r\n b'EglDisplay::Initialize()+0x0 [libGLESv2_adreno.so]'\r\n b'[unknown] [libEGL.so]'\r\n b'[unknown] [libandroid_runtime.so]'\r\n b'[unknown] [boot-framework.oat]'\r\n```\r\n\r\nStack traces with this commit:\r\n```\r\n_ZN10EglDisplay10InitializeEv\r\n b'EglDisplay::Initialize()+0x0 [libGLESv2_adreno.so]'\r\n b'android::egl_display_t::initialize(int*, int*)+0x128 [libEGL.so]'\r\n b'android::uirenderer::renderthread::EglManager::initialize()+0x94 [libhwui.so]'\r\n b'android::uirenderer::renderthread::EglManager::createSurface(ANativeWindow*, bool)+0x30 [libhwui.so]'\r\n b'android::uirenderer::skiapipeline::SkiaOpenGLPipeline::setSurface(android::Surface*, android::uirenderer::renderthread::SwapBehavior, android::uirenderer::renderthread::ColorMode)+0x58 [libhwui.so]'\r\n b'android::uirenderer::renderthread::CanvasContext::setSurface(android::sp<android::Surface>&&)+0x58 [libhwui.so]'\r\n b'android::uirenderer::WorkQueue::process()+0xac [libhwui.so]'\r\n b'android::uirenderer::renderthread::RenderThread::threadLoop()+0xf8 [libhwui.so]'\r\n b'android::Thread::_threadLoop(void*)+0x11c [libutils.so]'\r\n b'__pthread_start(void*)+0x28 [libc.so]'\r\n b'__start_thread+0x48 [libc.so]'\r\n\r\n_ZN10EglDisplay10InitializeEv\r\n b'EglDisplay::Initialize()+0x0 [libGLESv2_adreno.so]'\r\n b'android::egl_display_t::initialize(int*, int*)+0x128 [libEGL.so]'\r\n b'android_eglInitialize(_JNIEnv*, _jobject*, _jobject*, _jintArray*, int, _jintArray*, int)+0x154 [libandroid_runtime.so]'\r\n b'[unknown] [boot-framework.oat]'\r\n```ghprbCommentBody[buildbot, test this please]ghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="fix debug file lookup in bcc_elf_symbol_str" href="https://github.com/iovisor/bcc/pull/3016">PR #3016</a>: fix debug file lookup in bc...#60112515117460664bcc-pr #601601false6014816SUCCESS1594604672670https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/601/git601https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc25/601/601https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc26/601/601https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc27/601/601https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc28/601/601https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=ubuntu1604/601/601https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=ubuntu1710/601/601https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=ubuntu1804/601/