GitHub pull request #3201 of commit f8aaec1a4052a8a14bb1b823b7ddb42299dbeee2, no merge conflicts.sha1origin/pr/3201/mergeghprbActualCommitf8aaec1a4052a8a14bb1b823b7ddb42299dbeee2ghprbActualCommitAuthorghprbActualCommitAuthorEmailghprbAuthorRepoGitUrlhttps://github.com/juchem/bcc.gitghprbTriggerAuthorghprbTriggerAuthorEmailghprbTriggerAuthorLoginyonghong-songghprbTriggerAuthorLoginMention@yonghong-songghprbPullId3201ghprbTargetBranchmasterghprbSourceBranchpatch-1GIT_BRANCHpatch-1ghprbPullAuthorEmailghprbPullAuthorLoginjuchemghprbPullAuthorLoginMention@juchemghprbPullDescriptionGitHub pull request #3201 of commit f8aaec1a4052a8a14bb1b823b7ddb42299dbeee2, no merge conflicts.ghprbPullTitlefixing build when ENABLE_CLANG_JIT is disabledghprbPullLinkhttps://github.com/iovisor/bcc/pull/3201ghprbPullLongDescriptionattempting a cmake build with `ENABLE_CLANG_JIT` disabled and not `PYTHON_ONLY` fails with the following output:\r\n```\r\nroot@4ec15b1c6d03:~/src/bcc/tmp# cmake -DBUILD_SHARED_LIBS=OFF -DBUILD_STATIC_LIBS=ON -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD:STRING=20 -DCMAKE_C_FLAGS=\"-fPIC\" -DCMAKE_INSTALL_PREFIX:PATH=/root/opt -DENABLE_CPP_API=ON -DENABLE_LLVM_NATIVECODEGEN=ON -DENABLE_LLVM_SHARED=OFF -DENABLE_MAN=OFF -DENABLE_RTTI=OFF -DINSTALL_CPP_EXAMPLES=OFF -DENABLE_CLANG_JIT=OFF ../src\r\n-- Latest recognized Git tag is v0.17.0\r\n-- Git HEAD is ad5b82a5196b222ed2cdc738d8444e8c9546a77f\r\n-- Revision is 0.17.0-ad5b82a5\r\nCMake Error at src/cc/CMakeLists.txt:31 (string):\r\n string sub-command REGEX, mode MATCH needs at least 5 arguments total to\r\n command.\r\n\r\n\r\nCMake Error at src/cc/CMakeLists.txt:61 (if):\r\n if given arguments:\r\n\r\n \"VERSION_EQUAL\" \"6\" \"OR\" \"VERSION_GREATER\" \"6\"\r\n\r\n Unknown arguments specified\r\n\r\n\r\n-- Configuring incomplete, errors occurred!\r\nSee also \"/root/src/bcc/tmp/CMakeFiles/CMakeOutput.log\".\r\n```\r\n\r\nThe reason for the failure is that `LLVM` is required by [`src/cc/CMakeLists.txt`](https://github.com/iovisor/bcc/blob/297512a31ecc9ceebf79bda169350dace0f36757/src/cc/CMakeLists.txt#L61), which is included for non `PYTHON_ONLY` builds by [`src/CMakeLists.txt`](https://github.com/iovisor/bcc/blob/297512a31ecc9ceebf79bda169350dace0f36757/src/CMakeLists.txt#L16). Yet, `LLVM` is only looked up by [`/CMakeLists.txt`](https://github.com/iovisor/bcc/blob/297512a31ecc9ceebf79bda169350dace0f36757/CMakeLists.txt#L54) whenever `ENABLE_CLANG_JIT` is enabled.\r\n\r\nThe proposed fix looks up `LLVM` whenever `PYTHON_ONLY` is disabled, even if `ENABLE_CLANG_JIT` is disabled.\r\n\r\nThis is the output after the fix is applied:\r\n```\r\nroot@4ec15b1c6d03:~/src/bcc/tmp# cmake -DBUILD_SHARED_LIBS=OFF -DBUILD_STATIC_LIBS=ON -DBUILD_TESTING=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD:STRING=20 -DCMAKE_C_FLAGS=\"-fPIC\" -DCMAKE_INSTALL_PREFIX:PATH=/root/opt -DENABLE_CPP_API=ON -DENABLE_LLVM_NATIVECODEGEN=ON -DENABLE_LLVM_SHARED=OFF -DENABLE_MAN=OFF -DENABLE_RTTI=OFF -DINSTALL_CPP_EXAMPLES=OFF -DENABLE_CLANG_JIT=OFF ../src\r\n-- The C compiler identification is GNU 10.2.1\r\n-- The CXX compiler identification is GNU 10.2.1\r\n-- Detecting C compiler ABI info\r\n-- Detecting C compiler ABI info - done\r\n-- Check for working C compiler: /usr/bin/cc - skipped\r\n-- Detecting C compile features\r\n-- Detecting C compile features - done\r\n-- Detecting CXX compiler ABI info\r\n-- Detecting CXX compiler ABI info - done\r\n-- Check for working CXX compiler: /usr/bin/c++ - skipped\r\n-- Detecting CXX compile features\r\n-- Detecting CXX compile features - done\r\n-- Latest recognized Git tag is v0.17.0\r\n-- Git HEAD is ad5b82a5196b222ed2cdc738d8444e8c9546a77f\r\n-- Revision is 0.17.0-ad5b82a5\r\n-- Performing Test HAVE_NO_PIE_FLAG\r\n-- Performing Test HAVE_NO_PIE_FLAG - Success\r\n-- Performing Test HAVE_REALLOCARRAY_SUPPORT\r\n-- Performing Test HAVE_REALLOCARRAY_SUPPORT - Success\r\n-- Found BISON: /usr/bin/bison (found version \"3.7.4\")\r\n-- Found FLEX: /usr/bin/flex (found version \"2.6.4\")\r\n-- Found LLVM: /usr/local/include 11.0.0\r\n-- Found LibElf: /usr/local/lib/libelf.so\r\n-- Performing Test ELF_GETSHDRSTRNDX\r\n-- Performing Test ELF_GETSHDRSTRNDX - Success\r\n-- Configuring done\r\n-- Generating done\r\nCMake Warning:\r\n Manually-specified variables were not used by the project:\r\n\r\n BUILD_STATIC_LIBS\r\n BUILD_TESTING\r\n INSTALL_CPP_EXAMPLES\r\n\r\n\r\n-- Build files have been written to: /root/src/bcc/tmp\r\nroot@4ec15b1c6d03:~/src/bcc/tmp# make -j`nproc --all`\r\nScanning dependencies of target bpf-static\r\nScanning dependencies of target bpf-shared\r\n[ 2%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf.c.o\r\n[ 5%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/bpf.c.o\r\n[ 8%] Building C object src/cc/CMakeFiles/bpf-shared.dir/perf_reader.c.o\r\n[ 14%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf.c.o\r\n[ 14%] Building C object src/cc/CMakeFiles/bpf-static.dir/perf_reader.c.o\r\n[ 17%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/bpf.c.o\r\n[ 20%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/bpf_prog_linfo.c.o\r\n[ 23%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/bpf_prog_linfo.c.o\r\n[ 32%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/btf.c.o\r\n[ 32%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/btf_dump.c.o\r\n[ 32%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/btf.c.o\r\n[ 35%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/btf_dump.c.o\r\n[ 38%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/hashmap.c.o\r\n[ 41%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/hashmap.c.o\r\n[ 44%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/libbpf.c.o\r\n[ 47%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/libbpf.c.o\r\n[ 50%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/libbpf_errno.c.o\r\n[ 52%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/libbpf_errno.c.o\r\n[ 55%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/libbpf_probes.c.o\r\n[ 58%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/libbpf_probes.c.o\r\n[ 61%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/netlink.c.o\r\n[ 64%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/netlink.c.o\r\n[ 67%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/nlattr.c.o\r\n[ 70%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/nlattr.c.o\r\n[ 73%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/ringbuf.c.o\r\n[ 76%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/ringbuf.c.o\r\n[ 79%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/str_error.c.o\r\n[ 82%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/xsk.c.o\r\n[ 85%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/str_error.c.o\r\n[ 88%] Building C object src/cc/CMakeFiles/bpf-static.dir/libbpf/src/xsk.c.o\r\n[ 91%] Linking C static library libbcc_bpf.a\r\n[ 94%] Linking C shared library libbcc_bpf.so\r\n[ 94%] Built target bpf-static\r\nScanning dependencies of target bps\r\n[ 97%] Building C object introspection/CMakeFiles/bps.dir/bps.c.o\r\n[ 97%] Built target bpf-shared\r\n[100%] Linking C executable bps\r\n[100%] Built target bps\r\nroot@4ec15b1c6d03:~/src/bcc/tmp#\r\n```ghprbCommentBody[buildbot, test this please]ghprbGhRepositoryiovisor/bccghprbCredentialsId6d3daf13-69b8-48b1-9c8f-ec5353264113false<a title="fixing build when ENABLE_CLANG_JIT is disabled" href="https://github.com/iovisor/bcc/pull/3201">PR #3201</a>: fixing build when ENABLE_CL...#76413412717460664bcc-pr #764764false7646114SUCCESS1609267304297https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/764/git764https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc25/764/764https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc26/764/764https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc27/764/764https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=fc28/764/764https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=ubuntu1604/764/764https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=ubuntu1710/764/764https://buildbot.iovisor.org/jenkins/user/yonghong-song/my-views/view/all/job/bcc-pr/label=ubuntu1804/764/